Skip to content

Fix typo in MassMomentOfInertia.TonneSquareMilimeter#1490

Merged
angularsen merged 2 commits into
angularsen:release/v6from
lipchev:fix-unit-names
Jan 4, 2025
Merged

Fix typo in MassMomentOfInertia.TonneSquareMilimeter#1490
angularsen merged 2 commits into
angularsen:release/v6from
lipchev:fix-unit-names

Conversation

@lipchev
Copy link
Copy Markdown
Collaborator

@lipchev lipchev commented Jan 3, 2025

Renaming MassMomentOfInertia.TonneSquareMilimeter to MassMomentOfInertia.TonneSquareMillimeter (as part of #1200 )

Comment thread Common/UnitEnumValues.g.json Outdated
Comment on lines +968 to +971
"TonneSquareMilimeter": 28
"TonneSquareMilimeter": 28,
"KilotonneSquareMillimeter": 30,
"MegatonneSquareMillimeter": 37,
"TonneSquareMillimeter": 32
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This maybe a little hack-y, but I think that if we changed these by hand (to the old values) - I think they would stick.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For fixing typos, we can definitely tweak these by hand to match the old values 👍

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 23a68bc

Copy link
Copy Markdown
Owner

@angularsen angularsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you said, let's change the Common/UnitEnumValues.g.json to match the old values. I can't think of a scenario where this breaks, since it is practically the same unit with a different name.

Other than that, just go ahead and merge this when ready.

@angularsen angularsen merged commit ddf6134 into angularsen:release/v6 Jan 4, 2025
@lipchev lipchev deleted the fix-unit-names branch April 11, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants