Skip to content

Moved the ExceptionHelper to the Exceptions folder and updated the Skip reason for the unknown unit tests#1599

Merged
lipchev merged 6 commits into
angularsen:masterfrom
lipchev:grouping-exceptions
Aug 9, 2025
Merged

Moved the ExceptionHelper to the Exceptions folder and updated the Skip reason for the unknown unit tests#1599
lipchev merged 6 commits into
angularsen:masterfrom
lipchev:grouping-exceptions

Conversation

@lipchev
Copy link
Copy Markdown
Collaborator

@lipchev lipchev commented Aug 9, 2025

  • moved the ExceptionHelper to the Exceptions folder
  • replaced the Skip reason for the tests that cause a stack overflow

@lipchev
Copy link
Copy Markdown
Collaborator Author

lipchev commented Aug 9, 2025

@angularsen I was hoping that simply un-skipping the tests would be enough (now that we're throwing the UnitNotFoundException instead of NotImplementedException) - but unfortunately that wasn't the case:

        var quantity = Length.FromMeters(1);
        var invalidQuantity = new Length(1, (LengthUnit)(-1));
        Assert.Throws<UnitNotFoundException>(() => invalidQuantity.Equals(quantity, quantity));
        Assert.Throws<UnitNotFoundException>(() => quantity.Equals(quantity, invalidQuantity));

The first assert works as expected, but the second one enters an infinite recursion. The issue is also present in v5 (but not in the 🐲 PR).

@lipchev lipchev merged commit 549a37b into angularsen:master Aug 9, 2025
1 check passed
@angularsen
Copy link
Copy Markdown
Owner

Ok, as long as a fix is already in place in the bigger PR we'll ignore it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants