Flow, revolution, Pressure, Localization, Unittests#7
Merged
angularsen merged 4 commits intoangularsen:masterfrom Nov 12, 2013
Merged
Flow, revolution, Pressure, Localization, Unittests#7angularsen merged 4 commits intoangularsen:masterfrom
angularsen merged 4 commits intoangularsen:masterfrom
Conversation
added 4 commits
November 8, 2013 12:13
2. Add MegaPascals & KilogramForcePerSquareCentimeter to Pressure 3. Add russian to UnitSystem
Owner
|
Thanks George, looks good. Merged. A few minor things I fixed:
Things I did not fix:
Also, may I propose a change in name for Revolution? For example AngularSpeed, RotationalSpeed or CyclicFrequency appear as good choices in my opinion. What do you think? Sources: |
Contributor
Author
|
Yes, I agree that the name "Revolution" is wrong. "Rotational Speed" will be more correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Added Flow, Revolution, changed Pressure, Unit, UnitConverter, UnitSystem (add Russian and invariant localization).
Add unittests for Flow, Revolution, change unittests for Pressure, UnitConverterTests, UnitValueTests.
All tests passed.