Skip to content

Fix TryParseFeetInches when current locale uses ' as number separator #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pgrawehr wants to merge 6 commits into from
Closed

Fix TryParseFeetInches when current locale uses ' as number separator #794

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b77e05b
Fix parsing feet/inches when thousands separator is '
pgrawehr May 22, 2020
c571add
Add extra locale test
pgrawehr May 26, 2020
4de3c57
Clarify and extend test purpose
pgrawehr May 28, 2020
54a8df1
Adjust to Nullable-Changes
pgrawehr May 28, 2020
0d24b46
Ensure this works regardless of whatever kind of apostrophe is used
pgrawehr May 28, 2020
310db24
Use predefined enum type for what we want
pgrawehr May 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions UnitsNet.Tests/QuantityIFormattableTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,10 @@ public void SFormatEqualsSignificantDigits(string sFormatString, string expected
public void FormattingUsesSuppliedLocale()
{
Temperature t = Temperature.FromDegreesCelsius(2012.1234);
CultureInfo c = CultureInfo.CreateSpecificCulture("de-CH");
CultureInfo c = new CultureInfo("de-CH", false);
string formatted = string.Format(c, "{0:g}", t);
Assert.Equal("2'012.12 °C", formatted);
// Let's be very explicit here
Assert.Equal("2" + c.NumberFormat.NumberGroupSeparator + "012" + c.NumberFormat.NumberDecimalSeparator + "12 °C", formatted);
}

/// <summary>
Expand All @@ -84,10 +85,10 @@ public void FormattingUsesSuppliedLocale()
public void FormatStringWorksWithSuppliedLocale()
{
Temperature t = Temperature.FromDegreesCelsius(2012.1234);
CultureInfo c = CultureInfo.CreateSpecificCulture("de-CH");
CultureInfo c = new CultureInfo("de-CH", false);

FormattableString f = $"{t:g}";
Assert.Equal("2'012.12 °C", f.ToString(c));
Assert.Equal("2" + c.NumberFormat.NumberGroupSeparator + "012" + c.NumberFormat.NumberDecimalSeparator + "12 °C", f.ToString(c));

// This does not work. Looks like a compiler bug to me.
// string f2 = $"{t:g}".ToString(c);
Expand Down