governance: init proposal#954

Merged

tzemanovic merged 13 commits intomasterfrom

fraccaman+grarco/governance-init-proposal

Apr 1, 2022

Member

Fraccaman commented Mar 10, 2022 •

edited

Loading

Added CLI commands:
- Submit on chain proposal
- Create offline proposal
- Query existing proposals
Added initial governance VP
Added governance parameters to genesis

Fraccaman requested a review from grarco

March 10, 2022 15:48

Fraccaman force-pushed the fraccaman+grarco/governance-init-proposal branch from 92ee130 to 6180a9f Compare

March 10, 2022 15:52

grarco approved these changes

View reviewed changes

Fraccaman marked this pull request as draft

March 11, 2022 09:21

Member Author

Fraccaman commented Mar 11, 2022

pls update wasm

Fraccaman marked this pull request as ready for review

March 11, 2022 15:09

Fraccaman requested review from cwgoes and tzemanovic

March 11, 2022 15:09

Member Author

Fraccaman commented Mar 11, 2022

pls update wasm

tzemanovic reviewed

View reviewed changes

Makefile Outdated Show resolved Hide resolved

Fraccaman mentioned this pull request

governance: vote #975

Merged

Fraccaman force-pushed the fraccaman+grarco/governance-init-proposal branch from 9be0a45 to c68d667 Compare

March 16, 2022 08:58

tzemanovic reviewed

View reviewed changes

apps/src/lib/cli.rs Outdated Show resolved Hide resolved

tzemanovic reviewed

View reviewed changes

apps/src/lib/cli.rs Outdated Show resolved Hide resolved

tzemanovic reviewed

View reviewed changes

apps/src/lib/cli/context.rs Outdated Show resolved Hide resolved

tzemanovic reviewed

View reviewed changes

apps/src/lib/client/rpc.rs Outdated Show resolved Hide resolved

tzemanovic reviewed

View reviewed changes

apps/src/lib/client/tx.rs Outdated Show resolved Hide resolved

tzemanovic reviewed

View reviewed changes

apps/src/lib/config/genesis.rs Outdated Show resolved Hide resolved

tzemanovic reviewed

View reviewed changes

shared/src/ledger/governance/mod.rs Outdated Show resolved Hide resolved

tzemanovic reviewed

View reviewed changes

shared/src/ledger/governance/mod.rs Outdated Show resolved Hide resolved

tzemanovic reviewed

View reviewed changes

shared/src/ledger/governance/parameters.rs Outdated Show resolved Hide resolved

tzemanovic reviewed

View reviewed changes

shared/src/types/storage.rs Outdated Show resolved Hide resolved

tzemanovic reviewed

View reviewed changes

shared/src/types/transaction/mod.rs Show resolved Hide resolved

tzemanovic reviewed

View reviewed changes

tests/src/e2e/setup.rs Outdated Show resolved Hide resolved

tzemanovic suggested changes

View reviewed changes

tzemanovic left a comment

this is looking great! I just added couple suggestions

grarco commented Mar 22, 2022

pls update wasm

grarco force-pushed the fraccaman+grarco/governance-init-proposal branch from d652430 to 6477f59 Compare

March 22, 2022 16:27

grarco commented Mar 22, 2022

pls update wasm

Fraccaman added 2 commits

March 22, 2022 17:38


          [feat]: changed verifiers from hashset to btreeset to preserve order

83d837f


          [feat]: init proposal

b003312

Fraccaman and others added 5 commits

March 22, 2022 17:47


          [feat]: added e2e test, minors

f1b886b


          [feat]: improve offline serialization

0eb1d1d


          Refactoring + support multiple proposal in one tx

7e694ba


          Adds committing_proposal_key

ab6e8ae

[ci]: update wasm checksums


          Fixes Cargo.toml and unused import

077de9d

grarco force-pushed the fraccaman+grarco/governance-init-proposal branch from 405de3a to 077de9d Compare

March 22, 2022 17:06

grarco commented Mar 22, 2022

pls update wasm

Fraccaman and others added 4 commits

March 22, 2022 19:55


          [ci]: update wasm checksums

93f502c


          [fix]: missing wasm import

8c09f5f


          Fixes wrong features


          [fix]: commit key validation

5f5698f

Member Author

Fraccaman commented Mar 23, 2022

pls update wasm


          [ci]: update wasm checksums

1cb0c9a

tzemanovic approved these changes

View reviewed changes

tzemanovic left a comment

LGTM, thanks for the updates!


          changelog: add #954

849d371

tzemanovic added a commit to heliaxdev/anoma-network-config that referenced this pull request


          add gov. params for anoma/anoma#954

cdec169

tzemanovic commented Apr 1, 2022

I've added network config update for the next release heliaxdev/anoma-network-config#9

tzemanovic merged commit 8eeab64 into master

tzemanovic deleted the fraccaman+grarco/governance-init-proposal branch

April 1, 2022 11:15

tzemanovic reviewed

View reviewed changes

apps/src/lib/config/genesis.rs

                           tx_whitelist: config.parameters.tx_whitelist.unwrap_or_default(),
                       };
+                      let gov_params = GovParams {

tzemanovic Apr 7, 2022

check

tzemanovic reviewed

View reviewed changes

shared/src/ledger/governance/mod.rs

+                  H: 'static + StorageHasher,
+                  CA: 'static + WasmCacheAccess,
+              {
+                  is_valid_proposal_init_key_set(context, keys)

tzemanovic Apr 7, 2022

check

tzemanovic mentioned this pull request

update for Anoma 0.6.0 heliaxdev/anoma-network-config#9

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet