Merged
Conversation
brentstone
reviewed
Mar 5, 2024
Collaborator
|
Take the scripts out of the changelog commit |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2817 +/- ##
==========================================
- Coverage 60.24% 60.24% -0.01%
==========================================
Files 303 303
Lines 93191 93191
==========================================
- Hits 56145 56140 -5
- Misses 37046 37051 +5 ☔ View full report in Codecov by Sentry. |
dd6dde0 to
f3765ee
Compare
Collaborator
|
@grarco is this still needed? |
Collaborator
|
Yes, my bad, I forgot to add this to the queue of the last draft branch. I'll rebase it and mark it as ready for draft |
f3765ee to
64a08ed
Compare
brentstone
approved these changes
May 9, 2024
brentstone
added a commit
that referenced
this pull request
May 9, 2024
* bengt/light-sdk-clone: Changelog #2817 added clone to transaction structs
tzemanovic
added a commit
that referenced
this pull request
May 21, 2024
* tomas/split-up-apps: changelog: add #3259 test/apps_lib: fix the top-level dir check fix paths for split up namada_apps_lib git: ignore the new generated version.rs path symlink proto from `apps_lib` `mv crates/apps/build.rs crates/apps_lib/` `mv crates/apps_lib/src/lib/mod.rs crates/apps_lib/src/lib.rs` `mv crates/apps/src/lib crates/apps_lib/src` apps_lib: add a new crate for apps lib crate fixup! Merge branch 'grarco/masp-fees' (#3217) fixup! Merge branch 'grarco/tx-batch' (#3103) fixup! Merge branch 'grarco/tx-batch' (#3103) fixup! Merge branch 'bat/fix/issue-1796' (#3226) fixup! Merge branch 'tiago/max-proposal-bytes-validation' (#3220) fixup! Merge branch 'tomas/more-checked-arith' (#3214) empty commit changelog: add #3216 deliberatly empty Changelog #2817 added clone to transaction structs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Derives
CloneandDebugfor the light sdk structs.Indicate on which release or other PRs this topic is based on
v0.35.1
Checklist before merging to
draft