Skip to content

added clone to transaction structs#2817

Merged
tzemanovic merged 2 commits intomainfrom
bengt/light-sdk-clone
May 21, 2024
Merged

added clone to transaction structs#2817
tzemanovic merged 2 commits intomainfrom
bengt/light-sdk-clone

Conversation

@bengtlofgren
Copy link
Copy Markdown
Contributor

@bengtlofgren bengtlofgren commented Mar 5, 2024

Describe your changes

Derives Clone and Debug for the light sdk structs.

Indicate on which release or other PRs this topic is based on

v0.35.1

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@brentstone
Copy link
Copy Markdown
Collaborator

Take the scripts out of the changelog commit

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.24%. Comparing base (4ed6229) to head (64a08ed).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2817      +/-   ##
==========================================
- Coverage   60.24%   60.24%   -0.01%     
==========================================
  Files         303      303              
  Lines       93191    93191              
==========================================
- Hits        56145    56140       -5     
- Misses      37046    37051       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco linked an issue Mar 9, 2024 that may be closed by this pull request
grarco added a commit that referenced this pull request Apr 29, 2024
@grarco grarco force-pushed the bengt/light-sdk-clone branch from dd6dde0 to f3765ee Compare April 29, 2024 13:21
@grarco grarco requested a review from brentstone April 29, 2024 13:22
@brentstone
Copy link
Copy Markdown
Collaborator

@grarco is this still needed?

@grarco
Copy link
Copy Markdown
Collaborator

grarco commented May 9, 2024

Yes, my bad, I forgot to add this to the queue of the last draft branch. I'll rebase it and mark it as ready for draft

@grarco grarco force-pushed the bengt/light-sdk-clone branch from f3765ee to 64a08ed Compare May 9, 2024 16:54
brentstone added a commit that referenced this pull request May 9, 2024
* bengt/light-sdk-clone:
  Changelog #2817
  added clone to transaction structs
tzemanovic added a commit that referenced this pull request May 21, 2024
* tomas/split-up-apps:
  changelog: add #3259
  test/apps_lib: fix the top-level dir check
  fix paths for split up namada_apps_lib
  git: ignore the new generated version.rs path
  symlink proto from `apps_lib`
  `mv crates/apps/build.rs crates/apps_lib/`
  `mv crates/apps_lib/src/lib/mod.rs crates/apps_lib/src/lib.rs`
  `mv crates/apps/src/lib crates/apps_lib/src`
  apps_lib: add a new crate for apps lib crate
  fixup! Merge branch 'grarco/masp-fees' (#3217)
  fixup! Merge branch 'grarco/tx-batch' (#3103)
  fixup! Merge branch 'grarco/tx-batch' (#3103)
  fixup! Merge branch 'bat/fix/issue-1796' (#3226)
  fixup! Merge branch 'tiago/max-proposal-bytes-validation' (#3220)
  fixup! Merge branch 'tomas/more-checked-arith' (#3214)
  empty commit
  changelog: add #3216
  deliberatly empty
  Changelog #2817
  added clone to transaction structs
@tzemanovic tzemanovic merged commit 2f81e28 into main May 21, 2024
@tzemanovic tzemanovic deleted the bengt/light-sdk-clone branch May 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clone trait needs to be implemented for all transactions

4 participants