Merged
Conversation
batconjurer
previously approved these changes
May 16, 2024
Collaborator
batconjurer
left a comment
batconjurer
left a comment
There was a problem hiding this comment.
Apart from a complaint I have about the pr this is based on top of, this looks fine to me.
| chain_ctx.shielded, | ||
| &client, | ||
| &io, | ||
| args.batch_size, |
Collaborator
There was a problem hiding this comment.
again, this shouldn't be removed.
Collaborator
Author
There was a problem hiding this comment.
This should be fixed now in the base PR
…e functions. Removes event for masp wrapper tx
brentstone
added a commit
that referenced
this pull request
May 16, 2024
* grarco/masp-fees: Changelog #3217 Assigns issues to TODOs Removes `wrapper_changed_keys` from `TxResult` Removes fee unshielding e2e test Removes fee unshielding integration tests Recomputes tx test fixture Recomputes wasm for tests modules Updates TODO comments Reworks sdk fee validation Renames `wrapper_fee_check` Removes error/functions related to fee unshielding Removes `descriptions_limit` protocol param Removes redundandt wrapper types Removes fee unshielding cli and tx args Removes `unshield_section_hash` from `WrapperTx`. Updates the relative functions. Removes event for masp wrapper tx
tzemanovic
added a commit
that referenced
this pull request
May 20, 2024
* origin/grarco/masp-fees: Changelog #3217 Assigns issues to TODOs Removes `wrapper_changed_keys` from `TxResult` Removes fee unshielding e2e test Removes fee unshielding integration tests Recomputes tx test fixture Recomputes wasm for tests modules Updates TODO comments Reworks sdk fee validation Renames `wrapper_fee_check` Removes error/functions related to fee unshielding Removes `descriptions_limit` protocol param Removes redundandt wrapper types Removes fee unshielding cli and tx args Removes `unshield_section_hash` from `WrapperTx`. Updates the relative functions. Removes event for masp wrapper tx
tzemanovic
added a commit
that referenced
this pull request
May 20, 2024
brentstone
added a commit
that referenced
this pull request
May 21, 2024
* origin/grarco/masp-fees: Changelog #3217 Assigns issues to TODOs Removes `wrapper_changed_keys` from `TxResult` Removes fee unshielding e2e test Removes fee unshielding integration tests Recomputes tx test fixture Recomputes wasm for tests modules Updates TODO comments Reworks sdk fee validation Renames `wrapper_fee_check` Removes error/functions related to fee unshielding Removes `descriptions_limit` protocol param Removes redundandt wrapper types Removes fee unshielding cli and tx args Removes `unshield_section_hash` from `WrapperTx`. Updates the relative functions. Removes event for masp wrapper tx
brentstone
added a commit
that referenced
this pull request
May 21, 2024
tzemanovic
added a commit
that referenced
this pull request
May 21, 2024
* tomas/split-up-apps: changelog: add #3259 test/apps_lib: fix the top-level dir check fix paths for split up namada_apps_lib git: ignore the new generated version.rs path symlink proto from `apps_lib` `mv crates/apps/build.rs crates/apps_lib/` `mv crates/apps_lib/src/lib/mod.rs crates/apps_lib/src/lib.rs` `mv crates/apps/src/lib crates/apps_lib/src` apps_lib: add a new crate for apps lib crate fixup! Merge branch 'grarco/masp-fees' (#3217) fixup! Merge branch 'grarco/tx-batch' (#3103) fixup! Merge branch 'grarco/tx-batch' (#3103) fixup! Merge branch 'bat/fix/issue-1796' (#3226) fixup! Merge branch 'tiago/max-proposal-bytes-validation' (#3220) fixup! Merge branch 'tomas/more-checked-arith' (#3214) empty commit changelog: add #3216 deliberatly empty Changelog #2817 added clone to transaction structs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Partially addresses #2597.
Removes the optional fee unshielding
Transactionobject fromWrapperTx. Removes/refactors associated functions, types and tests. Removes fee unshielding support from the client and the sdk.NOTE: with this PR only transactions that pay fees from the signer balance are accepted. If you need to test masp transactions you'll need to have enough funds in a transparent balance.
Indicate on which release or other PRs this topic is based on
#3103 (diffs for review: https://github.com/anoma/namada/pull/3217/files/7f4b6c1e6656ec44194562ad1e167b09d24170f4..cf52c605e33279f4f464b210a8e215a7138be809)
Checklist before merging to
draft