Fix transfer triggered vps

[grarco]

Describe your changes

Addresses a bug discovered while attempting shielded actions on campfire. With #2928 we stopped triggering vps for the addresses that do not occupy the first segment of a storage keys. This has an effect on transfers, since the balance keys have as their first address the multitoken account. Our current implementation of the transfer and multi-transfer prelude functions manually triggers the vp of the source, but we do nothing for the destination(s), so we are not triggering their vps right now.

This PR implements the followings:

• The multi token vp ensures that the vps of all the involved parties (sources and destinations) have been triggered
• The transfer and multi-trasnfer functions now also trigger the vps of the destinations
• The execute method of the ibc context triggers the vp of the involved address for all the packets we support
• The masp balance key is now part of the is_masp_key and is_masp_transfer_key to ensure correct validation
• Adds two new steps in the ibc test to test rejection of malformed transaction
• New unit test for the masp vp to verify that changing only the balance key is disallowed
• New unit test for the multitoken vp to verify that the relevant verifiers are triggered

Misc:

• Removes another usage of unwrap_or_default in the pgf vp which was not fixed in Propagates error from is_proposal_accepted #3700
• Adds a clippy lint to prevent the usage of unwrap_or_default on errors to avoid the above issue

Checklist before merging

• If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
  • This will require 2 reviewers to approve the changes

[codecov]

Codecov Report

Attention: Patch coverage is 85.93750% with 36 lines in your changes missing coverage. Please review.

Project coverage is 72.81%. Comparing base (f7830f6) to head (41583eb).
Report is 31 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/ibc/src/lib.rs	58.75%	33 Missing ⚠️
crates/node/src/shims/abcipp_shim_types.rs	0.00%	1 Missing ⚠️
crates/trans_token/src/vp.rs	98.78%	1 Missing ⚠️
crates/tx_prelude/src/token.rs	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3804      +/-   ##
==========================================
+ Coverage   72.78%   72.81%   +0.02%     
==========================================
  Files         338      338              
  Lines      103923   104164     +241     
==========================================
+ Hits        75637    75842     +205     
- Misses      28286    28322      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[batconjurer]

Does this only for NFT transfers? I'm confused about the choice of error type

[grarco]

You're right, could be both a fungible or non-fungible transfer. I've added a new error variant in 41583eb