only trigger VPs from a fst addr of a key segment#2928
Merged
tzemanovic merged 4 commits intomainfrom Apr 12, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2928 +/- ##
==========================================
- Coverage 53.44% 53.43% -0.02%
==========================================
Files 310 310
Lines 101574 101611 +37
==========================================
+ Hits 54288 54294 +6
- Misses 47286 47317 +31 ☔ View full report in Codecov by Sentry. |
tzemanovic
force-pushed
the
tomas/fst-addr-vps
branch
from
b8ae6dd to
2550d2d
Compare
8 tasks
tzemanovic
added a commit
that referenced
this pull request
Apr 1, 2024
* origin/tomas/fst-addr-vps: changelog: add #2928 benches: fix VPs exec to include verifiers from tx wasm/tx: insert_verifier from txs where needed state/write_log: only trigger VPs from a fst addr of a key segment
tzemanovic
added a commit
that referenced
this pull request
Apr 1, 2024
tzemanovic
added a commit
that referenced
this pull request
Apr 10, 2024
* origin/tomas/fst-addr-vps: changelog: add #2928 benches: fix VPs exec to include verifiers from tx wasm/tx: insert_verifier from txs where needed state/write_log: only trigger VPs from a fst addr of a key segment # Conflicts: # crates/benches/native_vps.rs # crates/benches/vps.rs # crates/tx_prelude/src/token.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
first step toward #2629 - the next step is to update VPs to enforce that
insert_verifierhas been called with an address that has to authorize the tx (#2934).Indicate on which release or other PRs this topic is based on
0.32.0
Checklist before merging to
draft