Merged
Conversation
2 tasks
sug0
reviewed
Nov 13, 2024
batconjurer
approved these changes
Nov 14, 2024
Collaborator
batconjurer
left a comment
There was a problem hiding this comment.
Apart from sug0's requested changes, this looks fine
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4019 +/- ##
==========================================
- Coverage 73.92% 73.91% -0.01%
==========================================
Files 341 341
Lines 106510 106496 -14
==========================================
- Hits 78740 78720 -20
- Misses 27770 27776 +6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
sug0
approved these changes
Nov 21, 2024
Collaborator
sug0
left a comment
There was a problem hiding this comment.
couple of nits but otherwise lgtm
3 tasks
mergify bot
added a commit
that referenced
this pull request
Nov 21, 2024
Improve speculative shielded ctx (backport #4019)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #3457.
Closes #2593.
Moved the transition to the
SpeculativeContextfrom the SDK to the client to have access to the (possible) tx result. The transition is now performed when:The transition is not performed when:
Added an integration test to verify the behavior of the client when in a speculative context.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo