Skip to content

Improve speculative shielded ctx (backport #4019)#4070

Merged
mergify[bot] merged 7 commits intomaint-0.45from
mergify/bp/maint-0.45/pr-4019
Nov 21, 2024
Merged

Improve speculative shielded ctx (backport #4019)#4070
mergify[bot] merged 7 commits intomaint-0.45from
mergify/bp/maint-0.45/pr-4019

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Nov 21, 2024

Describe your changes

Closes #3457.
Closes #2593.

Moved the transition to the SpeculativeContext from the SDK to the client to have access to the (possible) tx result. The transition is now performed when:

  • the submitted transaction is successfully applied
  • the transaction is broadcasted
  • the transaction is dumped to storage

The transition is not performed when:

  • the transaction gets dry-run
  • the transaction is loaded from storage

Added an integration test to verify the behavior of the client when in a speculative context.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #4019 done by [Mergify](https://mergify.com).

@grarco grarco self-requested a review November 21, 2024 10:47
@grarco grarco added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 21, 2024
@mergify mergify bot merged commit 0499a91 into maint-0.45 Nov 21, 2024
@mergify mergify bot deleted the mergify/bp/maint-0.45/pr-4019 branch November 21, 2024 10:48
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.05%. Comparing base (f1503cc) to head (4e02b54).
Report is 8 commits behind head on maint-0.45.

Additional details and impacted files
@@              Coverage Diff               @@
##           maint-0.45    #4070      +/-   ##
==============================================
- Coverage       74.05%   74.05%   -0.01%     
==============================================
  Files             341      341              
  Lines          106581   106567      -14     
==============================================
- Hits            78927    78913      -14     
  Misses          27654    27654              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant