Improve speculative shielded ctx (backport #4019)#4070
Merged
mergify[bot] merged 7 commits intomaint-0.45from Nov 21, 2024
Merged
Improve speculative shielded ctx (backport #4019)#4070mergify[bot] merged 7 commits intomaint-0.45from
mergify[bot] merged 7 commits intomaint-0.45from
Conversation
grarco
approved these changes
Nov 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## maint-0.45 #4070 +/- ##
==============================================
- Coverage 74.05% 74.05% -0.01%
==============================================
Files 341 341
Lines 106581 106567 -14
==============================================
- Hits 78927 78913 -14
Misses 27654 27654 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #3457.
Closes #2593.
Moved the transition to the
SpeculativeContextfrom the SDK to the client to have access to the (possible) tx result. The transition is now performed when:The transition is not performed when:
Added an integration test to verify the behavior of the client when in a speculative context.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repoThis is an automatic backport of pull request #4019 done by [Mergify](https://mergify.com).