fix(opencode): Allowing subagents to send tool permissions through the ACP correctly#13021
fix(opencode): Allowing subagents to send tool permissions through the ACP correctly#13021BryceRyan wants to merge 5 commits intoanomalyco:devfrom
Conversation
|
The following comment was made by an LLM, it may be inaccurate: Duplicate PR FoundPR #12136 - fix(acp): handle permission requests from child sessions This is a related PR addressing the same issue. According to your PR description, you noted that #12136 was created after your work, but your PR (#13021) handles infinitely nested subagent chains while #12136 appears to address the same core problem of propagating tool approval requests from subagents through the ACP connection. Related PR: PR #12584 - fix: propagate parent agent permissions to subagent child sessions This PR also relates to permissions handling between parent agents and subagents, though it may focus on a slightly different aspect (propagating permissions rather than approval requests). |
ecd525e to
4f6b929
Compare
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
Closes #12133
What does this PR do?
Forwards tool approval requests from subagents through the ACP connection. Does so by backtracking up the agent "callstack" until we find an agent session that is registered as an ACP. We then use that as the notification ID for tool approvals.
How did you verify your code works?
Ran a task that does a tool call in CodeCompanion.nvim using OpenCode ACP. Also ran a task that ran a task that did a tool call. Both asked for approval correctly and did not hang.
I saw after making this #12136, but keeping mine here as it is able to handle infinitely nested subagent chains.