feat(permission): extract inner commands from wrappers for permission matching#16724
Closed
Chetic wants to merge 1 commit into
Closed
feat(permission): extract inner commands from wrappers for permission matching#16724Chetic wants to merge 1 commit into
Chetic wants to merge 1 commit into
Conversation
…rmission matching When commands are wrapped in xargs, timeout, sudo, nice, nohup, etc., the permission system now extracts and checks the inner command against permission rules in addition to the wrapper command itself. This prevents bypassing deny rules like "rm *": "deny" by running "sudo rm -rf /". Closes anomalyco#9516 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #9516
Type of change
What does this PR do?
When commands are wrapped in
xargs,timeout,sudo, etc., the permission system only sees the wrapper command. A rule like"rm *": "deny"is bypassed when the command issudo rm -rf /because the system matches againstsudo, notrm.This adds a
BashWrappermodule that extracts inner commands from known wrapper commands. Both the wrapper and inner command(s) get checked against permission rules. The change is purely additive — existing behavior is unchanged, inner commands are additionally checked.Supported wrappers:
timeout,time,nice,nohup,ionice,stdbuf,watch,sudo,env,xargs,find -exec/-execdir. Nested wrappers are handled recursively (e.g.timeout 5 sudo gh apiextractsgh api).How did you verify your code works?
test/permission/wrapper.test.ts)test/tool/bash.test.ts)Screenshots / recordings
N/A — no UI changes.
Checklist