fix(config): load .env from config dir for {env:VAR} substitution#21197
Open
codedeep wants to merge 1 commit into
Open
fix(config): load .env from config dir for {env:VAR} substitution#21197codedeep wants to merge 1 commit into
codedeep wants to merge 1 commit into
Conversation
substitute() only checked process.env for {env:VAR} tokens.
If opencode is installed globally it never sees the project .env.
Now reads .env from the config file directory as fallback.
Shell variables still take priority over .env values.
Author
|
CI failure on Windows e2e is unrelated — flaky openStatusPopover selector and terminal-reconnect timeout. My change only touches config/paths.ts. |
This was referenced May 25, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
substitute() only checked process.env for {env:VAR} tokens. If opencode is installed globally it never sees the project .env.
Issue for this PR
Closes #21187
Related: #10458
Type of change
What does this PR do?
Without this fix the only way to provide tokens for MCP servers configured
via
{env:VAR}inopencode.jsonis to export them globally in the shellor hardcode them directly in the config file. Hardcoding secrets in a
git-tracked config is a security risk — accidental commits leak credentials.
This change makes
substitute()inconfig/paths.tsread a.envfilefrom the same directory as the config file being parsed. Variables found
there act as a fallback: shell/system env always takes priority so existing
workflows are not affected.
Also switches from raw
process.envtoEnv.get()to respect the existingper-instance environment isolation.
How did you verify your code works?
Defined a test variable only in the project
.env(not exported to shell).Confirmed
{env:VAR}inopencode.jsonresolved correctly at startup.Also verified projects with no
.envfile work the same as before.Screenshots / recordings
N/A — no UI changes.
Checklist