fix: adjust tui retry dialog logic to be more provider specific and error case specific#26366
Merged
Conversation
Collaborator
Author
|
/review |
Contributor
|
lgtm |
truenorth-lj
added a commit
to truenorth-lj/opencode
that referenced
this pull request
May 8, 2026
Reconciles RETRY_MAX_ATTEMPTS=3 cap on top of anomalyco#26366's retryable(error, provider) and policy({provider,...}) signature changes. The cap check runs before the retryable() classification, so it still terminates the schedule independently of provider-specific reasoning. Test pattern matches the upstream change: maxAttempts test now also passes provider: 'test' to policy().
truenorth-lj
added a commit
to truenorth-lj/opencode
that referenced
this pull request
May 9, 2026
Two cherry-picked tests on this fork branch were authored against an
older base and didn't compile cleanly when replayed onto current
origin/dev:
- test/session/retry.test.ts: SessionRetry.policy() now requires
provider: string per upstream PR anomalyco#26366. Added provider: "test"
to the cap-only test setup.
- test/acp/event-subscription.test.ts: the drain test still called
Instance.provide(...); upstream renamed to WithInstance.provide
everywhere else in the file. Aligned.
Production code is unchanged. Both fixups are test-only.
katosun2
pushed a commit
to katosun2/opencode
that referenced
this pull request
May 10, 2026
…rror case specific (anomalyco#26366)
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
…rror case specific (anomalyco#26366)
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
…rror case specific (anomalyco#26366)
avion23
pushed a commit
to avion23/opencode
that referenced
this pull request
Jun 10, 2026
…rror case specific (anomalyco#26366)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.