fix(config): allow web permission object rules#29225
Open
YOMXXX wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29041
Type of change
What does this PR do?
webfetchandwebsearchpermissions are meant to support pattern-based rules for URLs and search queries, but the config schema only accepted a flat action. That made object syntax fail during config load.This PR changes those two permission entries to accept rule objects, adds regression coverage for parsing and evaluating those rules, updates the related internal guidance, and regenerates the JS SDK type.
How did you verify your code works?
bun test test/config/config.test.tsfrompackages/opencodebun typecheckfrompackages/opencodebun typecheckfrompackages/sdk/jsbun turbo typecheckfrom the repo root.husky/pre-pushScreenshots / recordings
No UI changes.
Checklist