fix(tui): stop writing kv.json on every theme preview keystroke#29229
Open
lexlian wants to merge 1 commit into
Open
fix(tui): stop writing kv.json on every theme preview keystroke#29229lexlian wants to merge 1 commit into
lexlian wants to merge 1 commit into
Conversation
Add theme.preview() that changes the active theme without persisting to kv.json. Use preview() for cursor movement and filter changes in the theme dialog, set() only on confirm. Cancel restores via preview() instead of set(), avoiding unnecessary writes on every keystroke (anomalyco#28893).
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28893
Type of change
What does this PR do?
The
/themesdialog callstheme.set(value)on every cursor move and filter change, which unconditionally writes tokv.json. This causes theme thrashing during preview and potential corruption on abrupt exits.Added
theme.preview(name)which changes the active theme without writing to kv. The dialog usespreviewfor cursor navigation, filter changes, and cancel-restore, andsetonly when the user confirms. Also addedpreviewto theTuiThemeplugin interface.How did you verify your code works?
preview)Checklist