fix(opencode): wait for shell output drain#29230
Closed
YOMXXX wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29214
Type of change
What does this PR do?
ShellTool.runwas returning as soon as the child process exit code resolved. The output reader runs in a scoped fiber, so the scope could close before buffered stdout/stderr chunks were processed. That made short shell commands occasionally return(no output)even though the process printed text.This PR keeps the output reader fiber and waits for it to drain before building the final shell result. It also adds a deterministic regression test where the process exit resolves before the output stream emits.
How did you verify your code works?
bun test test/tool/shell.test.tsfrompackages/opencodebun test test/tool/shell.test.ts -t "falls back from terminal-only configured shell"frompackages/opencodebun typecheckfrompackages/opencodebun turbo typecheckfrom the repo root.husky/pre-pushScreenshots / recordings
No UI changes.
Checklist