Skip to content

fix(acp-next): map typed errors to request errors#29233

Merged
nexxeln merged 1 commit into
devfrom
nxl/add-acpnext-error-mapping
May 25, 2026
Merged

fix(acp-next): map typed errors to request errors#29233
nexxeln merged 1 commit into
devfrom
nxl/add-acpnext-error-mapping

Conversation

@nexxeln
Copy link
Copy Markdown
Member

@nexxeln nexxeln commented May 25, 2026

Summary

  • add typed Schema.TaggedErrorClass failures for acp-next validation, auth, unsupported operations, and safe internal failures
  • map those errors explicitly to @agentclientprotocol/sdk RequestError responses
  • add a small defect wrapper so unknown async failures return a safe internal error without leaking raw details
  • cover the mapping and sanitization behavior with unit tests

Testing

  • bun test test/acp-next/error.test.ts
  • bun typecheck

@nexxeln nexxeln merged commit 7a5a997 into dev May 25, 2026
12 checks passed
@nexxeln nexxeln deleted the nxl/add-acpnext-error-mapping branch May 25, 2026 15:25
HaleTom pushed a commit to HaleTom/opencode that referenced this pull request May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant