fix(config): handle os.userInfo() failure in container/sandbox environments#29289
Closed
LifeJiggy wants to merge 1 commit into
Closed
fix(config): handle os.userInfo() failure in container/sandbox environments#29289LifeJiggy wants to merge 1 commit into
LifeJiggy wants to merge 1 commit into
Conversation
…nments The loadInstanceState function calls os.userInfo().username to set a default username when none is configured. In minimal Docker/OCI containers or sandboxed environments where the passwd entry is unavailable, os.userInfo() throws an error. Wrap in try/catch with user fallback to prevent config initialization failure.
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29292
Type of change
What does this PR do?
The
loadInstanceState()function inconfig.tscallsos.userInfo().usernameto set a default username when none is configured. In minimal Docker/OCI containers where the passwd entry is unavailable,os.userInfo()throws an error, causing config initialization failure. The fix wraps the call in try/catch with a "user" fallback.How did you verify your code works?
os.userInfo()to throw ENOENT and verifies config loads with username = "user"Screenshots / recordings
N/A
Checklist