fix: convert display-width offsets to char indices when expanding paste extmarks#29712
Open
xodmd45-ctrl wants to merge 1 commit into
Open
fix: convert display-width offsets to char indices when expanding paste extmarks#29712xodmd45-ctrl wants to merge 1 commit into
xodmd45-ctrl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29711
Type of change
What does this PR do?
When submitting a prompt with pasted content after typing CJK characters, extmark
start/endpositions are display-width offsets (visual columns), not JS string indices. For CJK characters (visual width 2, string length 1), using these offsets directly withslice()cuts at wrong positions, causing[Pasted text]to appear literally in the submitted message.Added
visualOffsetToCharIndex()that walks the string accumulating visual width until reaching the target offset, then returns the corresponding character index. Used it to convert extmark positions before slicing.How did you verify your code works?
Tested by typing Korean characters in the prompt, pasting text after them, and submitting — the pasted content now correctly appears inline instead of
[Pasted text].Screenshots / recordings
N/A (TUI change, no visible UI difference when working correctly)
Checklist