Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/opencode/src/cli/cmd/plug.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,18 @@ export type PlugCtx = {
directory: string
}

const noopSpinner: Spin = {
start() {},
stop() {},
}

export function createPlugSpinner(isTTY = Boolean(process.stdout.isTTY)): Spin {
if (!isTTY) return noopSpinner
return spinner()
}

const defaultPlugDeps: PlugDeps = {
spinner: () => spinner(),
spinner: () => createPlugSpinner(),
log: {
error: (msg) => log.error(msg),
info: (msg) => log.info(msg),
Expand Down
20 changes: 19 additions & 1 deletion packages/opencode/test/plugin/install.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import fs from "fs/promises"
import path from "path"
import { parse as parseJsonc } from "jsonc-parser"
import { Filesystem } from "@/util/filesystem"
import { createPlugTask, type PlugCtx, type PlugDeps } from "../../src/cli/cmd/plug"
import { createPlugSpinner, createPlugTask, type PlugCtx, type PlugDeps } from "../../src/cli/cmd/plug"
import { tmpdir } from "../fixture/fixture"

function deps(global: string, target: string | Error): PlugDeps {
Expand Down Expand Up @@ -109,6 +109,24 @@ async function read(file: string) {
}

describe("plugin.install.task", () => {
test("uses a quiet spinner for non-TTY output", () => {
const writes: string[] = []
const original = process.stdout.write
process.stdout.write = ((chunk: string | Uint8Array) => {
writes.push(String(chunk))
return true
}) as typeof process.stdout.write
try {
const spin = createPlugSpinner(false)
spin.start("Installing plugin package...")
spin.stop("Plugin package ready")
} finally {
process.stdout.write = original
}

expect(writes).toEqual([])
})

test("writes both server and tui config entries", async () => {
await using tmp = await tmpdir()
const target = await plugin(tmp.path, ["server", "tui"])
Expand Down
Loading