fix(tui): render console org load errors inline#33040
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Switch org" dialog (
DialogConsoleOrg) loads orgs viaconsole.listOrgs({}, { throwOnError: true }). On failure the resource rejects and enters an errored state; readingorgs()inside theoptions/currentmemos then re-throws, which tears down the dialog instead of showing anything actionable.This is the same failure class fixed for the move dialog in #32241.
Fix
Catch the failure into a
loadErrorsignal so the rejected resource never reaches the memos, and render an inline error inside the dialog instead of crashing. Reuses theemptyViewslot added toDialogSelectin #32241:renderFilter={false},locked, andoptions={[]}in the error stateescdismisses; the dialog keeps the same shellNo source signal / refetch here, so the load is single-shot: success renders the list, failure renders the inline error.
Testing
bun typecheckandbun prettier --checkpass frompackages/tui.escdismisses cleanly, no crash.