Skip to content

Upgrade node to version 20 - #308

Merged
sbe-arg merged 1 commit into
anothrNick:masterfrom
jcvegan:chore/upgrade-node
Mar 21, 2024
Merged

Upgrade node to version 20#308
sbe-arg merged 1 commit into
anothrNick:masterfrom
jcvegan:chore/upgrade-node

Conversation

@jcvegan

@jcvegan jcvegan commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

Summary of changes

Update the node version from 18 to 20

Breaking Changes

Do any of the included changes break current behaviour or configuration?

(YES / NO)

How changes have been tested

List any unknowns

@jcvegan jcvegan changed the title Upgrade no to version 20 Upgrade node to version 20 Mar 21, 2024
@jcvegan jcvegan mentioned this pull request Mar 21, 2024
@sbe-arg
sbe-arg merged commit 88c2e1b into anothrNick:master Mar 21, 2024
@jcvegan

jcvegan commented Mar 21, 2024

Copy link
Copy Markdown
Contributor Author

@sbe-arg still same error :/

@sbe-arg

sbe-arg commented Mar 21, 2024

Copy link
Copy Markdown
Collaborator

Yup I have no idea whats going on.

@jcvegan

jcvegan commented Mar 21, 2024

Copy link
Copy Markdown
Contributor Author

@sbe-arg

sbe-arg commented Mar 21, 2024

Copy link
Copy Markdown
Collaborator

Its not allowing the github actions bot to create a tag basically but not sure why.

@jcvegan

jcvegan commented Mar 21, 2024

Copy link
Copy Markdown
Contributor Author

@sbe-arg maybe related to this ad-m/github-push-action#96. Can you check the branch protection rules and/or the config settings?

@sbe-arg

sbe-arg commented Mar 21, 2024

Copy link
Copy Markdown
Collaborator

Nope only @anothrNick can check those settings

@anothrNick

Copy link
Copy Markdown
Owner

Branch protection rule is on master to require PRs on commits.

Actions > General > Workflow permissions has Read and write permissions

Not sure what's going on here 🤔

@anothrNick

Copy link
Copy Markdown
Owner

@sbe-arg do we need to explicitly set the token for checkout v4? https://github.com/actions/checkout?tab=readme-ov-file#usage

Says the default is ${{ github.token }}

@sbe-arg

sbe-arg commented Mar 22, 2024

Copy link
Copy Markdown
Collaborator

I have no idea why this is happening to be honest.

If the actions settings did not change for this repo it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants