fix: pass in optional arguments to sqs#421
Merged
Merged
Conversation
hsong-rh
previously approved these changes
Apr 14, 2025
bzwei
reviewed
Apr 14, 2025
mkanoor
force-pushed
the
amazon_sqs_changes
branch
from
66823c9 to
f7feb6e
Compare
bzwei
previously approved these changes
Apr 14, 2025
Dostonbek1
requested changes
Apr 14, 2025
Dostonbek1
reviewed
Apr 14, 2025
mkanoor
force-pushed
the
amazon_sqs_changes
branch
from
f7feb6e to
8c16947
Compare
mkanoor
force-pushed
the
amazon_sqs_changes
branch
from
8c16947 to
0b68888
Compare
mkanoor
force-pushed
the
amazon_sqs_changes
branch
from
0b68888 to
41a1b1f
Compare
mkanoor
force-pushed
the
amazon_sqs_changes
branch
from
881ef11 to
9e1e0c2
Compare
Based on feedback we received we are missing some key parameters from sqs queue processing. Adding additional optional parameters * queue_owner_aws_account_id * max_number_of_messages
mkanoor
force-pushed
the
amazon_sqs_changes
branch
from
fabbfb3 to
2fdd89e
Compare
for more information, see https://pre-commit.ci
Dostonbek1
approved these changes
Apr 16, 2025
hsong-rh
approved these changes
Apr 16, 2025
github-project-automation
Bot
moved this from In Progress
to Review
in 🧰 devtools project board
bzwei
approved these changes
Apr 16, 2025
github-project-automation
Bot
moved this from Review
to Done
in 🧰 devtools project board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on feedback we received we are missing some key parameters from sqs queue processing. Adding additional optional parameters
https://issues.redhat.com/browse/AAP-42623
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sqs/client/get_queue_url.html
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sqs/client/receive_message.html