fix: slightly improve wait_for logic in project integration test#441
Merged
Conversation
Alex-Izquierdo
approved these changes
May 30, 2025
This replaces a task in the project sync integration test that used the "pause" module to wait for project creation to be completed. Now, a proper wait_for checks if the import status is "completed". In the scm_branch test we also now check if the import status is "completed" before continuing.
ptoscano
force-pushed
the
improve-project-test-wait_for
branch
from
5747a4a to
ded36b2
Compare
ptoscano
approved these changes
Jun 2, 2025
Contributor
ptoscano
left a comment
ptoscano
left a comment
There was a problem hiding this comment.
Thanks! Hopefully this should stabilize the "staging" integration test.
github-project-automation
Bot
moved this from Review
to Done
in 🧰 devtools project board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces a task in the project sync integration test that used the "pause" module to
wait for project creation to be completed. Now, a proper wait_for checks if the import
status is "completed".
In the scm_branch test we also now check if the import status is "completed" before continuing.