Add Token Based Authentication#467
Merged
Merged
Conversation
Alex-Izquierdo
previously approved these changes
Aug 25, 2025
Contributor
|
Certainly e2e tests are challenging to not say impossible, but I wonder if it would not be too much effort some basic unit coverage with mocking. https://github.com/ansible/event-driven-ansible/blob/main/tests/unit/plugins/module_utils/test_client.py I would not block the PR for it, LGTM as it is now. |
zkayyali812
requested review from
B-Whitt,
bzwei,
kaiokmo,
mkanoor and
ptoscano
mkanoor
approved these changes
Aug 29, 2025
kaiokmo
approved these changes
Aug 29, 2025
bzwei
approved these changes
Aug 29, 2025
zkayyali812
force-pushed
the
aap-51754
branch
from
6877921 to
f616cd3
Compare
github-project-automation
Bot
moved this from Review
to Done
in 🧰 devtools project board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR adds token based authentication.
Notably, significant testing using this token was not added, as it would require a larger refactor since our test infrastructure for this repository does not deploy an entire Ansible Automation Platform, but rather just EDA, and a platform token can't be generated in the context of only EDA.
Jira