Few lint fixes#507
Merged
Merged
Conversation
Contributor
ptoscano
commented
Feb 6, 2026
ptoscano
commented
- add another noqa for blocking code path
- split only once when possible
The function is loading the source file, and it only happens once (when starting the source). Also, the file opening few lines below is blocking too, so for now ignore the blocking is_file().
Only the first part before ':' is needed, so do not split more than once.
ttuffin
approved these changes
Feb 6, 2026
B-Whitt
approved these changes
Feb 6, 2026
github-project-automation
Bot
moved this from Review
to Done
in 🧰 devtools project board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.