-
Notifications
You must be signed in to change notification settings - Fork 140
feat: implement new gRPC transports #4354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…arity and maintainability
…/ansys/pymapdl into feat/implement-transports
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements new gRPC transport modes for PyMAPDL, adding support for Unix Domain Sockets (UDS), Windows Named Pipes (WNUA), and mutual TLS (mTLS) alongside the existing insecure transport. The implementation provides automatic transport selection based on platform and allows manual configuration through new parameters.
Key Changes:
- Added transport mode configuration with automatic platform-based selection (UDS on Linux, WNUA on Windows)
- Introduced new initialization parameters (
transport_mode,uds_dir,uds_id,certs_dir) for transport configuration - Integrated
ansys.tools.common.cyberchannelfor transport verification and channel creation
Reviewed changes
Copilot reviewed 297 out of 298 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/ansys/mapdl/core/mapdl_grpc.py | Core implementation of transport modes with configuration methods, channel creation updates, and UDS cleanup logic |
| src/ansys/mapdl/core/mapdl_core.py | Added transport-related parameters to the allowed parameters list |
| src/ansys/mapdl/core/launcher.py | Extended launch_mapdl signature with transport parameters and documentation |
| pyproject.toml | Pinned ansys-tools-common dependency to version 0.3.0 |
| .github/workflows/test-remote.yml | Configured test environment to use insecure transport mode |
| .github/workflows/test-local.yml | Configured test environment to use insecure transport mode |
| .ci/start_mapdl.sh | Added environment variable for insecure transport mode |
| .ci/build_matrix.sh | Added new MAPDL version v25.2-pre1-ubuntu-cicd to build matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4354 +/- ##
==========================================
- Coverage 91.27% 90.85% -0.43%
==========================================
Files 196 196
Lines 15977 16082 +105
==========================================
+ Hits 14583 14611 +28
- Misses 1394 1471 +77 🚀 New features to boost your workflow:
|
…/ansys/pymapdl into feat/implement-transports
Description
Implement new GRPC transports
Issue linked
NA
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)