fix: setting_sources=[] bug (issue #794)#806
Closed
nanookclaw wants to merge 1 commit intoanthropics:mainfrom
Closed
fix: setting_sources=[] bug (issue #794)#806nanookclaw wants to merge 1 commit intoanthropics:mainfrom
nanookclaw wants to merge 1 commit intoanthropics:mainfrom
Conversation
Replace truthiness check with explicit is not None check, matching tools handling. When setting_sources is an empty list, pass --setting-sources to disable all setting sources.
IgorTavcar
added a commit
to IgorTavcar/claude-agent-sdk-python
that referenced
this pull request
Apr 10, 2026
- anthropics#806: setting_sources=[] truthiness fix - anthropics#803: betas=[]/plugins=[] truthiness fix - anthropics#786: ThinkingBlock missing signature crash fix - anthropics#790: suppress ProcessError when result already received - anthropics#658: capture real stderr in ProcessError - anthropics#791: suppress stale task notifications between turns - anthropics#763: guard malformed CLAUDE_CODE_STREAM_CLOSE_TIMEOUT env var - anthropics#805: delete_session() cascades subagent transcript dir - anthropics#804: top-level skills option on ClaudeAgentOptions - anthropics#691: PostCompact hook event type support 479 tests passing, mypy clean, ruff clean. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
Closing — the upstream refactoring that introduced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace truthiness check with explicit is not None check, matching tools handling. When setting_sources is an empty list, pass --setting-sources "" to disable all setting sources.
This fixes issue #794 where setting_sources=[] was silently ignored due to a truthiness check.
Testing
All tests pass. Specifically: