-
-
Notifications
You must be signed in to change notification settings - Fork 582
feat: Add ability to download specific tool versions used by hooks. TLDR: add --hook-config=--tool-version=1.2.3 for pinning wrapped tool version. Works for all tools (even terraform and tofu) except checkov
#1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MaxymVlasov
wants to merge
21
commits into
master
Choose a base branch
from
downloadable_and_version_controlled_hooks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
869f6b6
chore(AI): Init OpenSpec skills, wire into AGENTS.md
MaxymVlasov 3707561
f
MaxymVlasov 0051ab7
Merge branch 'master' into openspec
MaxymVlasov f053b65
commit part that makes +- sense
MaxymVlasov 3df47b5
And commit a second part
MaxymVlasov c95abe6
Archive spec
MaxymVlasov e24e21b
Drop extralinks, as #1003 discarded
MaxymVlasov 4c23c39
Apply suggestions from code review - docs
MaxymVlasov 2e303f6
Rename function resolve_tool_version to resolve_tool_path
MaxymVlasov 2764a0e
Apply suggestions from code review - code, 1st round
MaxymVlasov c915e7b
Apply suggestions from code review
MaxymVlasov b0bc55b
Apply review suggestions and little improvements
MaxymVlasov a5e62cc
chore: untrack local openspec.ai tooling files
MaxymVlasov 4438ee8
Still ask AI to generate and use openspec, but do not commit skills
MaxymVlasov b85f444
fix(hooks): stop masking tool_path resolution failures
MaxymVlasov a432cff
revert: drop OpenSpec-related changes, moved to #1005
MaxymVlasov a475d47
fix(hooks): check terragrunt syntax version against tool_path, not $PATH
MaxymVlasov 4dfc05c
Merge branch 'master' into downloadable_and_version_controlled_hooks
MaxymVlasov 243e6f9
Apply suggestion from @MaxymVlasov
MaxymVlasov 1c881c1
Add table from PR review comments
MaxymVlasov 2ed31af
Fix numbering
MaxymVlasov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Avoid claiming every binary is downloaded from GitHub releases.
Terraform/OpenTofu resolution uses HashiCorp release installers, so this should say “the tool’s upstream release assets” (or similar) rather than specifically “GitHub releases.”
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see an issue here. "Github release" is more undersandable, IMO.
@yermulnik ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"GitHub releases" describes the feature, but e.g. "GitHub releases page" (or with capitalized "Releases" to mark the section on the web-site) describes the actual location where we download assets from.
So I'd add "page" after "releases" to provide clarity. However, tech-savvies do indeed often say "Github releases" meaning "Github Releases page" =)
Up to you 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.