Fix uv dependencies and update dataset link#33
Open
jcerveto wants to merge 2 commits intoantoniorv6:masterfrom
Open
Fix uv dependencies and update dataset link#33jcerveto wants to merge 2 commits intoantoniorv6:masterfrom
uv dependencies and update dataset link#33jcerveto wants to merge 2 commits intoantoniorv6:masterfrom
Conversation
antoniorv6
reviewed
Nov 28, 2025
Owner
antoniorv6
left a comment
antoniorv6
left a comment
There was a problem hiding this comment.
Mainly there are configuration changes. Although I think that some of them (.gitignore) are somewhat personal affairs.
Owner
There was a problem hiding this comment.
Is it necessary? This is most likely to be a self-configuration, more than a global project need.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI summary below...
This pull request updates the pretraining configuration and adds several new dependencies to the project. The most significant change is the update to the data source for pretraining, which may affect the training results. Additionally, multiple new packages have been added to support new functionality or improve existing features.
Configuration update:
data_pathinconfig/FP-GrandStaff/pretraining.jsonfrom"antoniorv6/grandstaff-ekern"to"PRAIG/fp-grandstaff", updating the dataset used for pretraining.Dependency additions:
verovio,wand,cairosvg,names, andwonderwordsto the dependencies list inpyproject.toml, likely to support music notation rendering, image processing, SVG conversion, and name/word generation features.