Updated the maven-enforcer-plugin to 3.0.0-M3#19
Merged
Conversation
…detection to be successful in later versions of Java.
ctubbsii
approved these changes
Apr 16, 2020
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
Thanks for the PR @volmasoft ; By the way, in future, there is no need to create an issue first, if you are going to immediately submit a PR. A PR serves as its own issue on GitHub. Sometimes it is useful to create an issue first, but it is not strictly required by the project's developers.
If you wish to be added as a contributor to https://accumulo.apache.org/people/ , please open a pull request to add yourself at https://github.com/apache/accumulo-website/edit/master/pages/people.md and leave a reference to apache/accumulo-proxy#19 in your commit log.
If you intend to be a regular contributor to Accumulo projects, please consider subscribing to our developer mailing list (https://accumulo.apache.org/contact-us/) and introducing yourself. 😺
dongjoon-hyun
pushed a commit
to apache/orc
that referenced
this pull request
Sep 16, 2021
### What changes were proposed in this pull request? While working on another PR, I found the head of main failed in GA with the failure like below. ```Error: Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce (enforce-java-version) on project orc: Execution enforce-java-version of goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce failed: An API incompatibility was encountered while executing org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce: java.lang.ExceptionInInitializerError: null Error: ----------------------------------------------------- Error: realm = plugin>org.apache.maven.plugins:maven-enforcer-plugin:1.4.1 Error: strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy Error: urls[0] = file:/Users/runner/.m2/repository/org/apache/maven/plugins/maven-enforcer-plugin/1.4.1/maven-enforcer-plugin-1.4.1.jar ... Error: Number of foreign imports: 1 Error: import: Entry[import from realm ClassRealm[maven.api, parent: null]] Error: Error: -----------------------------------------------------: begin 0, end 3, length 2 Error: -> [Help 1] Error: Error: To see the full stack trace of the errors, re-run Maven with the -e switch. Error: Re-run Maven using the -X switch to enable full debug logging. Error: Error: For more information about the errors and possible solutions, please read the following articles: Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginContainerException make[2]: *** [java/shims/orc-shims-1.8.0-SNAPSHOT.jar] Error 1 make[1]: *** [java/CMakeFiles/java_build.dir/all] Error 2 make: *** [all] Error 2 Error: Process completed with exit code 2. ``` Google a bit and found a similar issue: apache/accumulo-proxy#19 This PR is a draft to see if the same change could work here ( since I don't have specific env like failed CI) ### Why are the changes needed? Recover `compile` and `package` without tests. ### How was this patch tested? Manual. ``` mvn compile mvn package -DskipTests ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full details of this change and reasoning behind it is in issue #18
I upgraded the maven-enforcer-plugin version from 1.4.1 to 3.0.0-M3
Have verified it builds locally for me under Java 14 and packages to a tarball correctly.
Have also stood up the binary and confirmed that I can use Python against the accumulo-proxy to access a fluo-uno instantiated accumulo instance.