Refactored DfsLogger constructors to static methods that now call a p…#4192
Merged
ctubbsii merged 5 commits intoFeb 7, 2024
Merged
Conversation
…rivate constructors
DomGarguilo
reviewed
Jan 25, 2024
…ariable located in fromCounters.
…ariable located in fromCounters. fix bug
DomGarguilo
approved these changes
Jan 29, 2024
* Push params used only for creating a new file down into the open method and remove from DfsLogger fields * Remove unneeded second private constructor * Tweak method names * Remove unnecessary mock object from test
ctubbsii
approved these changes
Feb 7, 2024
Member
|
Thanks for the PR @ArbaazKhan1. I see you aren't listed on our "people" page, acknowledging contributors. If you wish to be added as a contributor to https://accumulo.apache.org/people/ , please open a pull request to add yourself at https://github.com/apache/accumulo-website/edit/main/pages/people.md and leave a reference to If you intend to be a regular contributor to Accumulo projects, please consider subscribing to our developer mailing list (https://accumulo.apache.org/contact-us/) and introducing yourself. 😺 |
ArbaazKhan1
added a commit
to ArbaazKhan1/accumulo-website
that referenced
this pull request
Feb 8, 2024
EdColeman
pushed a commit
to apache/accumulo-website
that referenced
this pull request
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made the dfslogger constructors private and now have them being called from static methods. To ensure that LogEntry can now be set as final in dfslogger, I removed the instantiation of it from the open() method and now have it initialized it in the newly created static method named fromCounters().