-
Notifications
You must be signed in to change notification settings - Fork 416
Improve community page layout alignment and accordion hover interaction #1400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
070c9e4 to
4f93973
Compare
choo121600
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good change overall👍
One small concern: removing the community--grid style could reduce the amount of information visible on a single page, which might require more scrolling to reach the “Are you a user?” section.
I’d be interested to hear your thoughts on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think this is a good idea. The idea - from the very beginning - was to show the two options that you have to be a part of the community - contribute and be a user. The idea was to make it "equal" - especially when you have wide-enough screen to show them both in two columns.
That was intentional, to show them immediately as to 'equal` options. If you change it the way you described - in pretty much all cases you will have to scroll down to see "are you a user" when you open the page which is a bad idea.
I would rather suggest you focus on fixing the grid to have minimum height (possibly expresed in ems or other "scalable" unit ) - that will make the two grids align - even if the text in some of those is not long enough (of course only if the width of the screen is enouhg to show both columns at the same time). This will fix the problem you described without breaking the intention of the page.
sure sir, i'll look into this & update the pr soon. |
a332407 to
f3ba5fb
Compare
|
i have updated the screenrecording video after changes, keeping both section on the page together but with good and proper alignment by giving some truncate property and good hover part. |
Nice! |
This PR improves the layout consistency and visual alignment of the Community page.
Previously, the page relied on a grid-based structure that caused uneven spacing and misalignment between sections.
Before changes: ( Poor visual alignment between related sections and uneven spacing )
beforechange.mp4
After changes: ( Clean, unified structure with improved hover behavior )
Afterchanges.mp4
Thanks : )