Adds initial router, routes, and placeholder views#14862
Conversation
|
Looks good! But I think the test will break. Could we update it to test the router (ie pipelines will render on |
ryanahamilton
force-pushed
the
ui_scaffold_routes
branch
2 times, most recently
from
39683c7 to
331ebf8
Compare
| </Center> | ||
| <Switch> | ||
| <Redirect exact path="/" to="/pipelines" /> | ||
| <Route exact path="/pipelines" component={Pipelines} /> |
There was a problem hiding this comment.
| <Route exact path="/pipelines" component={Pipelines} /> | |
| <Route exact path="/workflows" component={Workflows} /> |
etc?
Most of the place in Airflow docs we call it DAGs (most commonly) or Workflows less frequently. Pipeline is very rarely used.
There was a problem hiding this comment.
These are just placeholders, nothing is set in stone. Once we have a full picture of what the new information architecture looks like, we'll be seeking feedback.
| <Route exact path="/access/users/:id/edit" component={Users} /> | ||
| <Route exact path="/access/roles" component={Roles} /> | ||
|
|
||
| <Route exact path="/docs" component={Docs} /> |
There was a problem hiding this comment.
This was previously just a link out to docs -- do we need/want it to be a component now?
There was a problem hiding this comment.
Yes. Again, nothing set in stone, but we're thinking we can provide a better experience with a page like we mocked up in the POC.
|
| "webpack-cli": "^3", | ||
| "webpack-dev-server": "^3" | ||
| }, | ||
| "resolutions": { |
There was a problem hiding this comment.
What's this key for? Not seen this one before.
There was a problem hiding this comment.
A warning was bubbling up from Chakra UI. They're using a deprecated function from a dependency. resolutions let's us swap out their dependency to a slightly older one which doesn't fire the warning. We can remove it when Chakra releases an update.
See:
chakra-ui/chakra-ui#3459 (comment)
https://classic.yarnpkg.com/en/docs/selective-version-resolutions/
There was a problem hiding this comment.
Ohh yeah yarn fix for updating nested dependencies. Gotcha.
We can keep this if it's helpful.
There was a problem hiding this comment.
Yarn was erroring in the CI build so we're seeing if this caused it.
github-actions
Bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
ryanahamilton
force-pushed
the
ui_scaffold_routes
branch
2 times, most recently
from
358a44e to
5bf3c15
Compare
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
- fix linting with `skipLibCheck` - fix motion warning on test with `resolutions` in `package.json`
ryanahamilton
force-pushed
the
ui_scaffold_routes
branch
from
674c60e to
19f6241
Compare
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
Closing in favor of #14927 |
3 participants
Resolves #14802.
This adds
react-router-domwith an initial collection of Routes and corresponding placeholder view components.