Skip to content

Add basic authentication to new UI#14988

Merged
ryanahamilton merged 9 commits into
apache:masterfrom
astronomer:ui-basic-auth
Mar 24, 2021
Merged

Add basic authentication to new UI#14988
ryanahamilton merged 9 commits into
apache:masterfrom
astronomer:ui-basic-auth

Conversation

@bbovenzi

@bbovenzi bbovenzi commented Mar 24, 2021

Copy link
Copy Markdown
Contributor

Initialize a very basic authentication flow to connect to the API and have public v private routes. This can be seen as a first step and there will be a second PR for authentication after #14219 is done.

This PR includes:

  • Login screen with basic loading and error states
  • Connecting to the API (w/ documentation on configuring env vars)
  • Context provider to handle all authentication
  • PrivateRoute to put views behind authentication
  • Added tests for the login screen and expanded the routing tests to include auth

Closes #14798


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Mar 24, 2021
Comment thread airflow/ui/test/utils.tsx Outdated
Comment thread airflow/ui/README.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 24, 2021
@ryanahamilton

Copy link
Copy Markdown
Contributor

Failures are unrelated to this PR. All of the files touched here live in airflow/ui/.

@ryanahamilton ryanahamilton merged commit d35bcae into apache:master Mar 24, 2021
@ryanahamilton ryanahamilton deleted the ui-basic-auth branch March 24, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuration API authentication (basic auth)

2 participants