Skip to content

[AIRFLOW-649] Support non-sched DAGs in LatestOnlyOp#1956

Closed
r39132 wants to merge 1 commit into
apache:masterfrom
r39132:master
Closed

[AIRFLOW-649] Support non-sched DAGs in LatestOnlyOp#1956
r39132 wants to merge 1 commit into
apache:masterfrom
r39132:master

Conversation

@r39132

@r39132 r39132 commented Dec 22, 2016

Copy link
Copy Markdown
Contributor

Dear Airflow Maintainers,

Please accept this PR that addresses the following issues:

Testing Done:

  • tested locally

Here's a screen shot, which shows 1 scheduled run and 2 manually triggered runs.
https://www.dropbox.com/s/vch7ohdx5he7xnw/Screenshot%202016-12-21%2023.10.22.png?dl=0

@r39132

r39132 commented Dec 22, 2016

Copy link
Copy Markdown
Contributor Author

@criccomini

@criccomini criccomini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Left a nit. If you feel compelled, go ahead and fix. Either way, good with a merge.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: not sure about newline in log message. Usually this is poor form, as it breaks parsers and whatnot.

@r39132

r39132 commented Dec 22, 2016

Copy link
Copy Markdown
Contributor Author

@criccomini Removed newline!

@codecov-io

codecov-io commented Dec 22, 2016

Copy link
Copy Markdown

Current coverage is 66.52% (diff: 0.00%)

Merging #1956 into master will decrease coverage by 0.03%

@@             master      #1956   diff @@
==========================================
  Files           135        135          
  Lines         10201      10204     +3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           6790       6788     -2   
- Misses         3411       3416     +5   
  Partials          0          0          

Powered by Codecov. Last update edf55cd...3286925

@asfgit asfgit closed this in 3cec728 Dec 22, 2016
alekstorm pushed a commit to alekstorm/incubator-airflow that referenced this pull request Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants