Skip to content

Typing support for operator mapping functions#21415

Merged
ashb merged 1 commit into
apache:mainfrom
astronomer:fix-mapping-mypy-errors
Feb 8, 2022
Merged

Typing support for operator mapping functions#21415
ashb merged 1 commit into
apache:mainfrom
astronomer:fix-mapping-mypy-errors

Conversation

@uranusjr

@uranusjr uranusjr commented Feb 8, 2022

Copy link
Copy Markdown
Member

Alternative to #21402 but more structured. Mostly extracted from #21328. I also implemented the same for @task_group; it doesn’t emit errors right now, but will start to once we implement mapping for it.

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Feb 8, 2022
@github-actions

github-actions Bot commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@uranusjr

uranusjr commented Feb 8, 2022

Copy link
Copy Markdown
Member Author

@dstandish Could you check is this work for you instead of #21402?

@dstandish dstandish left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ashb ashb merged commit 8fe9783 into apache:main Feb 8, 2022
@ashb ashb deleted the fix-mapping-mypy-errors branch February 8, 2022 19:58
@jedcunningham jedcunningham added area:dynamic-task-mapping AIP-42 changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) labels Mar 1, 2022
@jedcunningham jedcunningham added this to the Airflow 2.3.0 milestone Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dynamic-task-mapping AIP-42 changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants