Skip to content

[AIRFLOW-1443] Update Airflow configuration documentation - #2467

Closed
allisonwang wants to merge 1 commit into
apache:masterfrom
allisonwang:allison--update-doc
Closed

[AIRFLOW-1443] Update Airflow configuration documentation#2467
allisonwang wants to merge 1 commit into
apache:masterfrom
allisonwang:allison--update-doc

Conversation

@allisonwang

Copy link
Copy Markdown
Contributor

Dear Airflow maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

  • My PR addresses the following Airflow-1443 issues and references them in the PR title.

Description

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@aoen

@mention-bot

Copy link
Copy Markdown

@allisonwang, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jlowin, @boristyukin and @sekikn to be potential reviewers.

Comment thread docs/configuration.rst Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For grammar and because try number is really no more special than dag_id/execution_date (it's part of the key), let's changes this to:
Logs are stored in the log folder as dag_id/task_id/execution_date/try_number.log.

@aoen

aoen commented Jul 21, 2017

Copy link
Copy Markdown
Contributor

cc @bolkedebruin

@codecov-io

codecov-io commented Jul 21, 2017

Copy link
Copy Markdown

Codecov Report

Merging #2467 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2467   +/-   ##
=======================================
  Coverage   69.98%   69.98%           
=======================================
  Files         146      146           
  Lines       11446    11446           
=======================================
  Hits         8011     8011           
  Misses       3435     3435

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9109d6...815f67f. Read the comment docs.

@allisonwang
allisonwang force-pushed the allison--update-doc branch from 345cff0 to 5167c75 Compare July 21, 2017 23:09
@bolkedebruin

Copy link
Copy Markdown
Contributor

Please also update UPDATING.md. People that do log rotation from the OS will need to reconfigure. Please also correct the commit message to reflect what you are updating in the docs.

Comment thread docs/configuration.rst Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add some angle brackets so it is clear they are templated variables, itwill read a bit better

@allisonwang
allisonwang force-pushed the allison--update-doc branch from 5167c75 to 815f67f Compare August 9, 2017 18:52
@aoen

aoen commented Aug 9, 2017

Copy link
Copy Markdown
Contributor

LGTM

@asfgit asfgit closed this in 6825d97 Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants