Skip to content

fix: set dry_run to be optional. #35167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eladkal merged 5 commits into from
Nov 25, 2023
Merged

fix: set dry_run to be optional. #35167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5039da5
fix: set dry_run to be optional.
Oct 24, 2023
ac206f6
Update tests/api_connexion/schemas/test_task_instance_schema.py
eladkal Oct 27, 2023
7d0687f
Removed extra whitespace.
Oct 30, 2023
61b6655
Merge branch 'dryrun_fix' of https://github.com/austinau/airflow into…
Oct 30, 2023
ededf38
Merge branch 'main' into dryrun_fix
eladkal Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow/api_connexion/schemas/task_instance_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def validate_form(self, data, **kwargs):
class SetTaskInstanceStateFormSchema(Schema):
"""Schema for handling the request of setting state of task instance of a DAG."""

dry_run = fields.Boolean(dump_default=True)
dry_run = fields.Boolean(load_default=True)
task_id = fields.Str(required=True)
execution_date = fields.DateTime(validate=validate_istimezone)
dag_run_id = fields.Str()
Expand Down
16 changes: 16 additions & 0 deletions tests/api_connexion/schemas/test_task_instance_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,22 @@ def test_success(self):
}
assert expected_result == result

def test_dry_run_is_optional(self):
data = self.current_input.copy()
data.pop("dry_run")
result = set_task_instance_state_form.load(self.current_input)
expected_result = {
"dry_run": True,
"execution_date": dt.datetime(2020, 1, 1, 0, 0, tzinfo=dt.timezone(dt.timedelta(0), "+0000")),
"include_downstream": True,
"include_future": True,
"include_past": True,
"include_upstream": True,
"new_state": "failed",
"task_id": "print_the_context",
}
assert expected_result == result

@pytest.mark.parametrize(
"override_data",
[
Expand Down