[AIRFLOW-2896] Improve HdfsSensor() - #3746
Closed
XD-DENG wants to merge 1 commit into
Closed
Conversation
XD-DENG
force-pushed
the
hdfs_sensor.filter_for_ignored_ext
branch
5 times, most recently
from
August 14, 2018 23:41
9ee9741 to
1fa8de3
Compare
1. Make documentation clearer (format for `ignored_ext` should be extensions like ''py rather than '.py'). 2. Ensure upper/lower case would not affect the usage of `ignored_ext` feagure. 3. Add tests for methods filter_for_ignored_ext() and filter_for_filesize().
XD-DENG
force-pushed
the
hdfs_sensor.filter_for_ignored_ext
branch
from
August 15, 2018 01:16
1fa8de3 to
f87923a
Compare
Member
Author
|
1 out of 9 tests failed due to
Not sure whether it's a Travis-CI issue. |
Contributor
|
Hdfs is being refactored in #3560 and I think this is then already outdated |
Member
Author
|
Thanks @bolkedebruin . Didn't know the refactoring going on. Will close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
ignored_extshould be extensions like 'py' rather than '.py')ignored_extfeagure.filter_for_ignored_ext()andfilter_for_filesize()Tests
Commits
Documentation
Code Quality
git diff upstream/master -u -- "*.py" | flake8 --diff