Avoid logging empty line KPO#38247
Conversation
hussein-awala
left a comment
There was a problem hiding this comment.
Why do we need to filter empty log lines? From the reported issue, I see we have a problem with None, but IMHO we have to keep empty lines because the user may want to log them. WDYT?
(requested a change to avoid merging it before discussing the solution)
I'm ok to change the check to None only.
WDYT if I'll change pod_manager.py check to if message_to_log is not None:i.e just avoid printing None |
|
Hey @hussein-awala, would you like to review this one again? Thank you! |
|
Any updates on this? The last version seems to answer all problems and all demands. |
b69ea85 to
edc62a7
Compare
|
Thanks a lot! |
closes: #38105
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.