-
Notifications
You must be signed in to change notification settings - Fork 17.3k
Prevent start trigger initialization in scheduler #39585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Lee-W
merged 19 commits into
apache:main
from
astronomer:remove-start-trigger-initialization-from-scheduler
Jun 11, 2024
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
9070360
fix(baseoperator): change start_trigger into start_trigger_cls and st…
Lee-W 12905ab
refactor(taskinstance): extract common logic in defer_task
Lee-W 22e6760
refactor(baseoperator): refactor start trigger arguments as a datacla…
Lee-W f88e60d
docs(deferring): update docs for newly introduced StartTriggerArgs
Lee-W 14199cc
feat(baseoperator): add start_from_trigger as the flag to decide whet…
Lee-W df71b44
fix(taskinstance): fix unexpected commit
Lee-W a669068
fix(taskinstance): add _defer_task_from_task_deferred
Lee-W 6731ab4
docs(deferring): update version added
Lee-W e32ff04
refactor: rename defer_task_from_* methods
Lee-W 80ae6eb
fix(dagrun): remove uncessary conditions on scheduling tasks
Lee-W 009bcd1
fix(taskinstance): remove unnecessay check on trigger_kwargs
Lee-W 758b2e8
fix(dagrun): set start_date before deferring task from scheduler
Lee-W ed94608
refactor(triggers): move StartTriggerArgs to airflow.triggers.base
Lee-W dfa47ec
refactor: merge _defer_task* as _defer_task function
Lee-W 4568a59
refactor(taskinstance): deduplicate defer_task logic
Lee-W f1e4462
style: fix mypy warning
Lee-W 415993a
refactor: reorder parameter as suggested
Lee-W 91f8b30
docs(deferring): reword description as suggested
Lee-W e1805e5
refactor: make argument "exception" in defer_task method required for…
Lee-W File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.