fix: trim leading // character using mysql backend#40401
Merged
Conversation
claneys
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
claneys
force-pushed
the
fix/leading-character-kedaConnection
branch
from
ebee0f3 to
46afc56
Compare
13 tasks
Using mysql backend needs to compute a connection string without scheme which using the urlJoin templating function left the // characters at the beginning of the string Signed-off-by: Romain Forlot <romain.forlot@dailymotion.com>
claneys
force-pushed
the
fix/leading-character-kedaConnection
branch
from
46afc56 to
dbf1735
Compare
utkarsharma2
added
the
changelog:skip
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
Using mysql backend needs to compute a connection string without scheme which using the urlJoin templating function left the // characters at the beginning of the string Signed-off-by: Romain Forlot <romain.forlot@dailymotion.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using mysql backend needs to compute a connection string without scheme which using the urlJoin templating function left the // characters at the beginning of the string. This PR trim those characters to get a correct mysql connection string.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.