Skip to content

Remove logging for "blocked" events#40446

Merged
potiuk merged 1 commit into
apache:mainfrom
ayushjain2809:rm-blocked-event-log
Jul 2, 2024
Merged

Remove logging for "blocked" events#40446
potiuk merged 1 commit into
apache:mainfrom
ayushjain2809:rm-blocked-event-log

Conversation

@ayushjain2809

@ayushjain2809 ayushjain2809 commented Jun 26, 2024

Copy link
Copy Markdown
Contributor

Also rectified docstring for "/blocked" endpoint

#37580 updated audit logs to exclude read-only events; but it also added logging "blocked" event which appears to be an oversight. I believe it was due to incorrect docstring for the "/blocked" endpoint.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg Bot added the area:webserver Webserver related Issues label Jun 26, 2024
@boring-cyborg

boring-cyborg Bot commented Jun 26, 2024

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@ayushjain2809 ayushjain2809 force-pushed the rm-blocked-event-log branch from 5c5abb7 to a5c92ff Compare June 26, 2024 21:53

@hussein-awala hussein-awala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, LGTM

@ayushjain2809 ayushjain2809 force-pushed the rm-blocked-event-log branch 2 times, most recently from 8166e4f to adcfc3c Compare July 2, 2024 20:09
@ayushjain2809

Copy link
Copy Markdown
Contributor Author

Hi, can this be merged?
I believe the tests after @hussein-awala's approval failed due to reasons unrelated to this PR.

@potiuk potiuk force-pushed the rm-blocked-event-log branch from adcfc3c to 20a4ea4 Compare July 2, 2024 20:55
@potiuk

potiuk commented Jul 2, 2024

Copy link
Copy Markdown
Member

Rebased to check.

@potiuk potiuk merged commit ed6849e into apache:main Jul 2, 2024
@boring-cyborg

boring-cyborg Bot commented Jul 2, 2024

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@ayushjain2809 ayushjain2809 deleted the rm-blocked-event-log branch July 3, 2024 04:23
@utkarsharma2 utkarsharma2 added the type:misc/internal Changelog: Misc changes that should appear in change log label Jul 12, 2024
@utkarsharma2 utkarsharma2 added this to the Airflow 2.9.3 milestone Jul 12, 2024
utkarsharma2 pushed a commit that referenced this pull request Jul 12, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants