Disable rendering for doc_md#40522
Merged
Merged
Conversation
amoghrajesh
reviewed
Jul 1, 2024
hussein-awala
left a comment
hussein-awala
left a comment
Member
There was a problem hiding this comment.
IMHO we should add a condition for file paths, like reading the file without render the content
if doc_md.endswith(".md"):
return open(doc_md, "r").read()with a try/except in case the file is not found.
Lee-W
force-pushed
the
disable-rendering-for-doc-md
branch
from
f6f0110 to
e4d7197
Compare
potiuk
reviewed
Jul 1, 2024
eladkal
approved these changes
Jul 1, 2024
Lee-W
force-pushed
the
disable-rendering-for-doc-md
branch
from
e4d7197 to
90109c0
Compare
Lee-W
force-pushed
the
disable-rendering-for-doc-md
branch
from
90109c0 to
732a0e2
Compare
Member
Author
|
Changed a test case after approval. I'm planning on merging this late too night. Please let me know if anyone want to take a look |
potiuk
approved these changes
Jul 2, 2024
Member
|
LGTM. Marked it as 2.9.3 |
utkarsharma2
pushed a commit
that referenced
this pull request
Jul 2, 2024
(cherry picked from commit 8159f6e)
ephraimbuddy
pushed a commit
that referenced
this pull request
Jul 2, 2024
(cherry picked from commit 8159f6e)
35 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.