Skip to content

Resolve google secret manager deprecations in tests #40548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jul 2, 2024
Merged

Resolve google secret manager deprecations in tests #40548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions tests/deprecations_ignore.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,6 @@
- tests/providers/google/cloud/operators/test_vertex_ai.py::TestVertexAICreateHyperparameterTuningJobOperator::test_execute
- tests/providers/google/cloud/operators/test_vertex_ai.py::TestVertexAIDeleteAutoMLTrainingJobOperator::test_execute
- tests/providers/google/cloud/operators/test_vertex_ai.py::TestVertexAIDeleteCustomTrainingJobOperator::test_execute
- tests/providers/google/cloud/secrets/test_secret_manager.py::TestCloudSecretManagerBackend::test_connections_prefix_none_value
- tests/providers/google/cloud/secrets/test_secret_manager.py::TestCloudSecretManagerBackend::test_get_conn_uri
- tests/providers/google/cloud/secrets/test_secret_manager.py::TestCloudSecretManagerBackend::test_get_conn_uri_non_existent_key
- tests/providers/google/cloud/sensors/test_gcs.py::TestTsFunction::test_should_support_cron
- tests/providers/google/cloud/sensors/test_gcs.py::TestTsFunction::test_should_support_datetime
- tests/providers/google/cloud/transfers/test_azure_fileshare_to_gcs.py::TestAzureFileShareToGCSOperator::test_execute
Expand Down
6 changes: 3 additions & 3 deletions tests/providers/google/cloud/secrets/test_secret_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def test_get_conn_uri(self, mock_client_callable, mock_get_creds, connections_pr

secrets_manager_backend = CloudSecretManagerBackend(connections_prefix=connections_prefix)
secret_id = secrets_manager_backend.build_path(connections_prefix, CONN_ID, SEP)
returned_uri = secrets_manager_backend.get_conn_uri(conn_id=CONN_ID)
returned_uri = secrets_manager_backend.get_conn_value(conn_id=CONN_ID)
assert CONN_URI == returned_uri
mock_client.secret_version_path.assert_called_once_with(PROJECT_ID, secret_id, "latest")

Expand All @@ -131,7 +131,7 @@ def test_get_conn_uri_non_existent_key(self, mock_client_callable, mock_get_cred
secrets_manager_backend = CloudSecretManagerBackend(connections_prefix=CONNECTIONS_PREFIX)
secret_id = secrets_manager_backend.build_path(CONNECTIONS_PREFIX, CONN_ID, SEP)
with caplog.at_level(level=logging.DEBUG, logger=secrets_manager_backend.client.log.name):
assert secrets_manager_backend.get_conn_uri(conn_id=CONN_ID) is None
assert secrets_manager_backend.get_conn_value(conn_id=CONN_ID) is None
assert secrets_manager_backend.get_connection(conn_id=CONN_ID) is None
assert re.search(
f"Google Cloud API Call Error \\(NotFound\\): Secret ID {secret_id} not found",
Expand Down Expand Up @@ -226,7 +226,7 @@ def test_connections_prefix_none_value(self, mock_client_callable, mock_get_cred
secrets_manager_backend = CloudSecretManagerBackend(connections_prefix=None)

mock_is_valid_prefix_sep.assert_not_called()
assert secrets_manager_backend.get_conn_uri(conn_id=CONN_ID) is None
assert secrets_manager_backend.get_conn_value(conn_id=CONN_ID) is None
mock_get_secret.assert_not_called()

@mock.patch(MODULE_NAME + ".get_credentials_and_project_id")
Expand Down