Add D1 pydocstyle rules to pyproject.toml#40569
Merged
Merged
Conversation
potiuk
approved these changes
Jul 3, 2024
utkarsharma2
added
the
type:misc/internal
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 0 for #40567
Followup to the discussion here, I'm explicitly adding the D1## rules to the exclude list and making them more obvious that we want to implement them.
I included D107 because it was part of the initial plan but I'd actually suggest that we do not want D107 enabled. Forcing docstrings in
__init__methods feels like a bad idea to me, personally, but I'll go with the community consensus on this one.