Enhance start_trigger_args serialization#40993
Merged
phanikumv merged 2 commits intoJul 26, 2024
Merged
Conversation
Lee-W
force-pushed
the
enhance-start-trigger-args-serialization
branch
from
6e6489d to
a148d5b
Compare
phanikumv
force-pushed
the
enhance-start-trigger-args-serialization
branch
from
a148d5b to
263a659
Compare
Lee-W
force-pushed
the
enhance-start-trigger-args-serialization
branch
from
263a659 to
5036115
Compare
vatsrahul1001
approved these changes
Jul 26, 2024
phanikumv
approved these changes
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
In #39585,
StartTriggerArgswas introduced, but serialization was not handled correctly, which prevented some of the existing operators/triggers from utilizing this feature.What
Rewrite how
StartTriggerArgsis serialized throughBaseSerialization^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.